@b4n commented on this pull request.


> @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void)
        if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR))

This code could actually be simplified by basically having the same code path 
for the with and without config cases: just don't load the config if it doesn't 
exist, and then `utils_get_setting_integer()` will return the default.  But 
that's not for a point release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2645#pullrequestreview-525651827

Reply via email to