When running the unittests on Windows, all Ctags tests fail because TagManager writes the tag files with CRLF line endings but the tests compare against the test samples which have LF line endings (most of them). There is a probably easy solution: as @techee pointed out in https://github.com/geany/geany/pull/2666#issuecomment-734731377, writing the tag file in binary mode will use LF line endings when writing the tags file (and *should* have no effect on non-Windows systems :crossed_fingers:). There are six test samples which have CRLF line endings which still causes the tests to fail. Those could be converted to LF line endings: - 3184782.sql.tags - 3526726.tex.tags - bug1570779.sql.tags - ingres_procedures.sql.tags - matlab_backtracking.m.tags - matlab_test.m.tags
Apart from the Ctags unittests, we have some tests for various utility functions in https://github.com/geany/geany/blob/master/tests/test_utils.c where few filesystem related tests fail on Windows. Those could be probably `ifdef`'d for Windows and/or separate tests for Windows be added. Once these issues are fixed, we could enable `make check` in CI!? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2677
