@elextr requested changes on this pull request. First glance at it only a few comments, also for the Julia lexer could you add a diff that applies the three lines (I think you said) to backport it from Lexilla, probably best in the same place as scintilla_changes.patch and add a prompt to update_scintilla.sh to use it so the changes are known and can be re-applied if another backport is needed.
> @@ -129,14 +129,15 @@ comment_line_doc=comment_doc comment_doc_keyword=comment_doc,bold comment_doc_keyword_error=comment_doc,italic -number=0x007f00 +number=0x808000 Why the change to the default colour scheme? > @@ -138,3 +138,3283 @@ module=-module(%cursor%). export=-export(%cursor%). compile=-compile(%cursor%). include=-include(%cursor%). + +[Julia] This is a cunning way of getting the Julia latex input to work in Geany :-) but IIRC all the snippets for all languages are read at startup, is there a way this could be distributed in another way instead of every user of every language having several thousand Julia snippets loaded? As a user snippets somehow maybe? > @@ -153,6 +154,7 @@ identifier_4=identifier_1 string=0xff8000 string_1=string string_2=0x008000 +string_3=0x008000 Is this used? > +# MIME type +mime_type=text/x-julia + +# single comments, like # in this file +comment_single=# +# multiline comments +comment_open=#= +comment_close==# + +[indentation] +width=4 +# 0 is spaces, 1 is tabs, 2 is tab & spaces +type=0 + + +[build_settings] Please use the `[build_menu]` settings, all the old filetypes still use `[build_settings]` because I made the backwards compat too good and nobody has needed to change them :-) but lets make it right for new ones. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2584#pullrequestreview-687881603