@elextr commented on this pull request.


> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
        document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)
+{
+       guint i;
+       gint cur_page = 
gtk_notebook_get_current_page(GTK_NOTEBOOK(main_widgets.notebook));
+       
+       foreach_document(i)
+       {
+               if (! (documents[i]->file_name == NULL))

The problem with reload all is that even though it is user action, the user can 
have so many files open that not all the tabs are visible (guilty) so the user 
can forget that they have a buffer that is modified since they can't see the 
tab, and then reload all will lose their work.  The approach pointed out by 
@eht16 is the result of much discussion and I agree his suggestion to maintain 
that behaviour is reasonable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684731111

Reply via email to