@eht16 commented on this pull request.
> +# we're using lots of deprecated stuff with gtk3 (often because there is no
> proper alternative!)
+def_cflags += '-Wno-deprecated-declarations'
+def_cflags += '-DGDK_DISABLE_DEPRECATION_WARNINGS'
+def_cflags += '-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32'
+def_cflags += '-DGEANY_PREFIX="@0@"'.format(get_option('prefix'))
+foreach d : [ 'includedir', 'libdir', 'libexecdir', 'datadir', 'localedir' ]
+ def_cflags += '-DGEANY_@0@="@1@"'.format(d.underscorify().to_upper(),
join_paths(prefix, get_option(d)))
+endforeach
+def_cflags += '-DGEANY_DOCDIR="@0@"'.format(join_paths(prefix,
get_option('datadir'), 'doc'))
+
+# CFLAGS for everything else, i.e. most of Geany
+geany_cflags = def_cflags
+have_gcc4_visibility = cc.has_argument('-fvisibility=hidden')
+geany_cflags += '-DGEANY_PRIVATE'
+if target_machine.system() == 'windows'
+ geany_cflags += '-DGEANY_EXPORT_SYMBOL="__declspec(dllexport)"'
The quotes around `__declspec(dllexport)` must be removed otherwise we get
syntax errors, without the quotes the code compiles.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#pullrequestreview-744440871
