There was a mistake in my fix for wayland popups, as @b4n correctly noticed in 
https://github.com/geany/geany/pull/3011#issuecomment-1279825987. The problem 
was that the "Go to symbol definition" did not open the popup in 
correct location.

This PR contains two commits:
 - First fixes the problem
 - Second removes support for prehistoric versions of GTK
 
The first commit might be used separately, but I have to openly admit that the 
#ifdefed code is not tested, because I couldn't find any system in my reach 
with old enough GTK. The second commit should not be merged until GTK 3.24 is 
officially required for Geany. But I guess that it should not be a problem, 
this PR can probably wait untill then, since no one noticed the bug for a month.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3316

-- Commit Summary --

  * Fix go to symbol definition popup location
  * Drop support for GTK 3.21 and older

-- File Changes --

    M src/callbacks.c (2)
    M src/editor.c (2)
    M src/msgwindow.c (9)
    M src/notebook.c (8)
    M src/plugins.c (3)
    M src/prefs.c (21)
    M src/sidebar.c (8)
    M src/symbols.c (91)
    M src/ui_utils.c (26)
    M src/ui_utils.h (2)
    M src/vte.c (2)

-- Patch Links --

https://github.com/geany/geany/pull/3316.patch
https://github.com/geany/geany/pull/3316.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3...@github.com>

Reply via email to