@eht16 requested changes on this pull request.
Oh, and could you please add your plugin to the list in the top README?
> @@ -0,0 +1,32 @@
+Color brackets, parenthesis, and braces
+===================
RestructuredText (the text format used here) requires that underlines are
exactly as long as the heading above.
> @@ -0,0 +1,143 @@
+/*
+ * BracketMap.cc
+ *
+ * Copyright 2013 Asif Amin <asifa...@utexas.edu>
2013? I guess it's a typo :).
If so, ideally change all occurrences.
> @@ -0,0 +1,35 @@
+# =============================================================================
Are these two "ax_cxx_*" M4 macros copied from Geany?
> +
+ static Length& GetLength(Bracket &bracket) {
+ return std::get<0>(bracket);
+ }
+ static Order& GetOrder(Bracket &bracket) {
+ return std::get<1>(bracket);
+ }
+
+ static const Length& GetLength(const Bracket &bracket) {
+ return std::get<0>(bracket);
+ }
+ static const Order& GetOrder(const Bracket &bracket) {
+ return std::get<1>(bracket);
+ }
+};
+
Why so many empty lines?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#pullrequestreview-1284250581
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1221/review/1284250...@github.com>
