@b4n commented on this pull request.


>       {
-               gchar *new_cmd = dialogs_show_input(_("Select Browser"), 
GTK_WINDOW(main_widgets.window),
-                       _("Failed to spawn the configured browser command. "
-                         "Please correct it or enter another one."),
+               /* Uses the user's default browser akin to xdg-open (in flatpak 
through a portal) */
+               if (EMPTY(tool_prefs.browser_cmd))
+               {
+                       if 
(gtk_show_uri_on_window(GTK_WINDOW(main_widgets.window), uri, GDK_CURRENT_TIME, 
NULL))

If we do care about pre-3.22 GTK, it'd be easy enough to do something like that:
```c
#if GTK_CHECK_VERSION(3, 22, 0)
                        if 
(gtk_show_uri_on_window(GTK_WINDOW(main_widgets.window), uri, GDK_CURRENT_TIME, 
NULL))
#else
                        if 
(gtk_show_uri(gtk_widget_get_screen(main_widgets.window), uri, 
GDK_CURRENT_TIME, NULL))
#endif
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178#pullrequestreview-1304200350
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3178/review/1304200...@github.com>

Reply via email to