> Looks good to me, and its simple, just add # to every line except headings.

And also except empty lines.

> I would not worry about the indented example, after adding a #, it is no 
> longer an accurate example whichever way its done.

I actually don't think this is even a valid conf file syntax - Scintilla at 
least doesn't syntax-highlight the indented line as a comment and I think it 
"works" simply because the parser just discards it as it is no key-value pair.

> [begin rant] In fact the example should not be there, its in the manual, the 
> filetype files should not be turned into documentation surrogates. If it 
> wasn't for the fact that its in every filetype file I would say remove the 
> example, its not like its some horrendously important setting that everyone 
> uses, why should it alone have a copy of the manual above it? It should just 
> say "# false to place comment at start of line, true to place after indent, 
> see manual". Just one line like most other settings!! [end rant] Anyhow its 
> not part of this PR whatever is done with it.

Agree, the conf files would deserve a huge cleanup.

There's another problem (and not talking about the horrible wording of the 
comment below). Some values are already commented-out in the conf files so they 
end up with the double `#` as well:
```ini
## the following characters are these which a "word" can contains, see 
documentation
##wordchars=_abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789
```
We could try to do something smart and detect `=` in the line which would 
indicate it's a key-value pair and not to insert the extra `#` in this case, or 
just ignore this problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3413#issuecomment-1445465838
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3413/c1445465...@github.com>

Reply via email to