@b4n commented on this pull request.

Apart from the comment, and assuming the parsers and lexers are upstream's, 
LGTM (esp. if @techee likes it as well :))

> +     {'g', tm_tag_undef_t},
+       {'l', tm_tag_undef_t},

Don't we want to see at least global variables?  And even local ones would be 
nice, esp. as IIUC they are now not shown but can still be used for 
autocompletion (@techee?)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1752#pullrequestreview-1368127757
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/1752/review/1368127...@github.com>

Reply via email to