@6t8k commented on this pull request.


>       /* Not sure if we can really continue without DISPLAY. Fake X display 
> perhaps?
         *
         * This test seems to work, at least.
         */
-       gtk_init_check(&argc, &argv);
+       if(!gtk_init_check(&argc, &argv)) {
+               printf("GTK initialisation failed; skipping. Running inside a 
headless environment?\n");

Actually, you might want to consider changing that existing `printf` too, as 
its output might in principle interfere with TAP. `g_test_message` prefixes the 
message with `#`, which seems to be the equivalent of a comment, so it should 
be better practice.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3676#discussion_r1384190623
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3676/review/1716544...@github.com>

Reply via email to