> A perfectly good thing to put in a PR called "Various encodings conversion 
> fixes" he says hopefully? Maybe the lowest level function could display the 
> message if it was `force` otherwise don't worry about it because its just 
> Geany trying all encodings it knows again ;-)

Would you really like me to add this here, in addition to the already 
non-trivial changes, or should this be a follow-up?

I've got a few more cosmetic changes, including propagating the error better as 
you wished, as well as not showing knowingly unsupported encodings in the UI 
and removing a unnecessary control in the preferences regarding file encodings. 
 Should I shove everything here because it's encoding-related, or should we 
keep the "fix encodings conversion" separate from the more cosmetic stuff?

> It won't add any not supported by whoever made the list in `encodings.c`, but 
> hopefully in this time of Unicode that won't be many.

:crossed_fingers: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#issuecomment-1852882462
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3716/c1852882...@github.com>

Reply via email to