@eht16 commented on this pull request.


> +keyword_4=#7F7F7F;;false;true
+
+identifier=#3CCA62;;false;true
+identifier_1=#507875;;false;true
+identifier_2=#457C54;;false;true
+identifier_3=#256536;;false;true
+identifier_4=#8BBC98;;false;true
+
+string=#ffcd8b;;false;false
+string_1=#BFAC91;#1C1F26;false;false
+string_2=#BA9665;#1C1F26;false;false
+string_3=#CDA7A1;;false;false
+string_4=#A1CDCA;;false;false
+string_eol=#A1C1CD;;false;false
+character=#A86027;;false;false
+backticks=#008C39l;;false;false

> > Geany complains about the invalid color value:
> 
> Ouch! Thanks.
> 
> That 7th `l` character (not including `#` ) is actually `;`, but my finger 
> apparently slipped. Will remove it.

:)

> > Note also the selection style warning.
> 
> Yes, that I am aware of. Tried various combinations, it looks quite ok like 
> this.

It would be nice if we could avoid the warning.

> I noticed that the name of the file is `dark-spook.conf`, but Titled Name is 
> `DarkSpook`. Should I correct that as well ? From `DarkSpook` to `Dark Spook` 
> into config or I leave as is ?

I think this is OK, some other themes do this as well.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/68#discussion_r1439397914
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-themes/pull/68/review/1800344...@github.com>

Reply via email to