Hi, Docker user here. I have tested both filetype definitions, the one from this PR and the one from wiki. As far as I can tell, they are not much different. I have noticed only one visual difference and that is that the configuration from @andy5995 renders strings in `RUN` commands better (because it uses sh lexer). It also has more up-to-date keywords (contains `MAINTAINER`).
The other file from wiki claims to also support docker-compose files. That is IMHO not very good idea, because those formats are completely different and should not be mixed in single configuration file. It can only lead to worse behavior in both filetypes. As to whether the filetype should be bundled in Geany release: I'd definitely vote to include it. I am using Geany for years (I could probably say decades by now :sweat_smile:) and it never occurred to me to search for Docker filetype support on wiki. If it were installed with geany, I would definitely be a happier user. It is also much easier than having to set this up manually (even though the documentation is great). So I would vote to merge this (if I had any voting rights :smiley:) and perhaps remove the other version from wiki. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-1938691754 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3757/c1938691...@github.com>
