@andy5995 commented on this pull request.


> +
+static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata)
+{
+       GtkWidget *main_menu_item;
+
+       struct pindata *container = init_pindata();
+       container->plugin = plugin;
+
+       // Create a new menu item and show it
+       main_menu_item = gtk_menu_item_new_with_mnemonic("Pin Document");
+       gtk_widget_show(main_menu_item);
+       
gtk_container_add(GTK_CONTAINER(plugin->geany_data->main_widgets->tools_menu),
+               main_menu_item);
+       g_signal_connect(main_menu_item, "activate",
+               G_CALLBACK(pin_activate_cb), container);
+       g_signal_connect(pinned_view_vbox, "button-press-event",

No popup menu appears and I see in the console:

```
(geany:1064826): GLib-GObject-CRITICAL **: 10:20:24.486: invalid (NULL) pointer 
instance

(geany:1064826): GLib-GObject-CRITICAL **: 10:20:24.486: g_signal_connect_data: 
assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
```

I think using 'pinned_view_vbox' as the 2nd argument  here is not correct.

I get no compiler warnings.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#pullrequestreview-1880777708
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1308/review/1880777...@github.com>

Reply via email to