@b4n commented on this pull request.
> +static TMParserMapGroup group_LDSCRIPT[] = {
+};
This gives me:
```
src/tagmanager/tm_parser.c:1165:44: warning: ISO C forbids empty initializer
braces [-Wpedantic]
1165 | static TMParserMapGroup group_LDSCRIPT[] = {
| ^
src/tagmanager/tm_parser.c:1165:25: error: zero or negative size array
'group_LDSCRIPT'
1165 | static TMParserMapGroup group_LDSCRIPT[] = {
```
Might be related to my pedantic flags, but that's a bit problematic.
What about having actual groups, even if unused?
```suggestion
static TMParserMapGroup group_LDSCRIPT[] = {
{N_("Section"), TM_ICON_STRUCT, tm_tag_struct_t},
{N_("Symbol"), TM_ICON_METHOD, tm_tag_method_t | tm_tag_function_t},
{N_("Version"), TM_ICON_OTHER, tm_tag_other_t},
{N_("Input Section"), TM_ICON_NAMESPACE, tm_tag_namespace_t},
};
```
Or just a dummy one?
```suggestion
static TMParserMapGroup group_LDSCRIPT[] = {
{"unused", TM_ICON_NONE, tm_tag_undef_t},
};
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3859#pullrequestreview-2050853725
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3859/review/[email protected]>
