@b4n approved this pull request.

At first I thought you were silly indeed, because I couldn't reproduce the 
issue with a very simple build, and because I know the GTK API doesn't pulsate 
by itself, so it didn't make sense to me (and your OP wasn't clear enough for 
me to understand what's actually going one).

But then I tried with something a little heavier, meaning the progress bar had 
actually something more to do than merely maybe flashing, and I then could see 
it.  Then going over the progressbar sources, I understood what you meant by 
"tick", and why it actually made sense.  For the interested: although pulse 
steps have to be asked for explicitly (the progress bar doesn't simply start 
moving by itself), it still animates between pulse steps with a frame clock 
callback.  However, it seems it's not shut off when the progressbar gets 
hidden.  Setting a fraction value indeed leaves the so-called internal 
"activity mode" and disables the frame clock callback.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3902#pullrequestreview-2119368760
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3902/review/2119368...@github.com>

Reply via email to