@b4n commented on this pull request.


> +     gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean 
> definition, gpointer data);
+
+       /**
+        * Pointer to function called by Geany to check whether the plugin 
implements
+        * additional symbol (e.g. type) highlighting in Scintilla.
+        *
+        * @see @c autocomplete_provided() for more details.
+        * @note There is no function in the @c PluginExtension structure 
informing
+        * plugins to perform symbol highlighting. Plugins
+        * implementing symbol highlighting should perform it at the appropriate
+        * moments based on Scintilla and Geany events such as when the document
+        * becomes visible or when the document is modified.
+        *
+        * @since 2.1
+        **/
+       gboolean (*symbol_highlight_provided)(GeanyDocument *doc, gpointer 
data);

IIUC the issue is that it basically depends on when the symbols get ready, 
which is not something Geany can control for e.g. LSP. Sure, it could be added 
to various places, but for the case of the LSP plugin it would *never* be 
useful.  For other synchronous applications it could potentially be useful I 
guess, so possibly calling it where Geany already does might be a reasonable 
thing, and an async plugin would just do nothing there… dunno.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#discussion_r1660184463
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3849/review/2150055...@github.com>

Reply via email to