@techee commented on this pull request.

> so i think this feature is complete, if we are considering merging it - 

Agree, I think it's mostly ready.

I just had a look at the code once more and found some minor issues but nothing 
big.

> we should settle on config UI (either keep as is or change to point 
> https://github.com/geany/geany/pull/1 from 
> https://github.com/geany/geany/pull/3911#pullrequestreview-2136554129)
And probably rename everything to "persistent notepad" or something like that.

I've been thinking about it and maybe "persistent untitled documents" would be 
best so there's no new terminology. I still think it would be best to merge the 
configuration with "instant save" but depends on what others (@b4n @eht16) 
think.

Note that we seem to be in the middle of the "Geany summer vacation" period and 
even normally it takes quite some time to get things merged (so please be 
patient) but from me at least this PR has full support - it's very useful and 
it also fixes the issue with the most thumbs up reactions.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3480#pullrequestreview-2213164686
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3480/review/[email protected]>

Reply via email to