@eht16 approved this pull request.
Great.
Reviewed, tested, works fine!
Only one tiny nitpick, feel free to ignore it.
> @@ -475,6 +475,37 @@ void on_entry_tagfilter_activate(GtkEntry *entry,
> gpointer user_data)
}
+void on_entry_docfilter_changed(GtkAction *action, gpointer user_data)
+{
+ GeanyDocument *doc = document_get_current();
+ GtkEntry *filter_entry;
+
+ if (!doc)
+ return;
+
+ filter_entry = GTK_ENTRY(ui_lookup_widget(main_widgets.window,
"entry_docfilter"));
+ sidebar_openfiles_set_filter(gtk_entry_get_text(filter_entry));
+}
+
+
+void on_entry_docfilter_icon_press(GtkEntry *entry, GtkEntryIconPosition
icon_pos, GdkEvent *event, gpointer user_data)
We could save this callback if we use `ui_entry_add_clear_icon()` which does
the same and is just a convenience way of doing this.
But since it doesn't add any functionality, we can also leave it as is.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4210#pullrequestreview-2574326128
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4210/review/[email protected]>