@techee commented on this pull request.


>  EXTRA_DIST = \
        gnu_regex/README.txt
 
 libctags_la_LIBADD += libgnu_regex.la
-AM_CPPFLAGS += -I$(srcdir)/gnu_regex
+AM_CPPFLAGS += -I$(srcdir)/gnu_regex -D__USE_GNU

Yes, this works.

Though maybe the "correct" way is to have `__USE_GNU` defined consistently - 
when it's defined for the `gnu_regex` library, it should be defined also for 
users of the library otherwise there might be incompatible declarations coming 
from the header (not sure if it's really the case, seems to work fine).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4228#discussion_r1943799130
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4228/review/[email protected]>

Reply via email to