@frlan notified me in a PM that the Nix lexer doesn't show error indicators 
for unterminated one-line strings which makes them hard to spot. The same 
problem is also with the TOML, Dart, and Zig lexers I introduced in the 2.1 
release cycle.

This PR fixes the issue by introducing a STRINGEOL state similarly to other 
lexers and adds the necessary Geany style mapping. The lexilla part of this PR 
has already been merged upstream in 
https://github.com/ScintillaOrg/lexilla/pull/315.

Might be worth considering for 2.1 as I think it's rather low-risk.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/4306

-- Commit Summary --

  * dart: add lexer support for highlighting unterminated strings
  * nix: add lexer support for highlighting unterminated strings
  * zig: add lexer support for highlighting unterminated strings
  * toml: add lexer support for highlighting unterminated strings

-- File Changes --

    M data/filedefs/filetypes.dart (1)
    M data/filedefs/filetypes.nix (1)
    M data/filedefs/filetypes.toml (1)
    M data/filedefs/filetypes.zig (1)
    M scintilla/lexilla/include/SciLexer.h (4)
    M scintilla/lexilla/lexers/LexDart.cxx (13)
    M scintilla/lexilla/lexers/LexNix.cxx (13)
    M scintilla/lexilla/lexers/LexTOML.cxx (12)
    M scintilla/lexilla/lexers/LexZig.cxx (13)
    M src/highlighting.c (12)
    M src/highlightingmappings.h (10)

-- Patch Links --

https://github.com/geany/geany/pull/4306.patch
https://github.com/geany/geany/pull/4306.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4306
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/[email protected]>

Reply via email to