Those probably aren't an actual problem in real life (but maybe the `gtk_editable_set_position()` one), but `-Wconversion` warns about it, and it *could* be an issue (in theory).
@techee are you interested by something like this? It's definitely not complete, but I quickly got tired of replacing `int` with `intptr_t` over and over again :) If you're interested I *might* keep on going, or happily hand it over to you :) In any case, feel free to take whatever you like and drop the rest if you want any of it. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1437 -- Commit Summary -- * vimode: foreach_document() expects an unsigned * vimode: Use intptr_t for Scintilla int/position/line * vimode: Remove redundant definition of SSM * vimode: Explicit a couple of valid casts * vimode: Use proper prototypes * vimode: gtk_editable_set_position() accepts -1 for the end * vimode: Use types wide enough not to truncate the value -- File Changes -- M vimode/src/backends/backend-geany.c (2) M vimode/src/backends/backend-viw.c (2) M vimode/src/cmd-params.c (2) M vimode/src/cmd-params.h (28) M vimode/src/cmds/edit.c (80) M vimode/src/cmds/fold.c (20) M vimode/src/cmds/undo.c (4) M vimode/src/excmd-params.h (6) M vimode/src/excmd-prompt.c (18) M vimode/src/excmd-runner.c (16) M vimode/src/sci.c (2) M vimode/src/sci.h (16) M vimode/src/utils.c (32) M vimode/src/utils.h (10) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1437.patch https://github.com/geany/geany-plugins/pull/1437.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1437 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/[email protected]>
