b4n left a comment (geany/geany-plugins#1434)

…and it's fixed, unveiling what broke use of `AM_GNU_GETTEXT_VERSION` in the 
Windows build: the `--install` flag in `ACLOCAL_AMFLAGS`.  Don't ask me why, 
but I guess it leads to copying over copies of the gettext macros.
I like it better that way for 3 reasons:
- It's closer to what we have in Geany
- `AM_GNU_GETTEXT_VERSION` is a currently more common setup than 
`AM_GNU_GETTEXT_REQUIRE_VERSION` (although the latter likely has its benefit)
- My custom rule for re-generating GMO files when he source change works with 
this.  Admittedly it might be possible to update it, but if we don't know the 
details of the Makefile rules we risk breakage in the future, like I had here.  
And although it kind of looks like a hack, having stale translations when one 
updates the *.po* is confusing and annoying.

Unless there are objections, I think I'll merge this in a couple days™ 
:slightly_smiling_face: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1434#issuecomment-2913878890
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1434/[email protected]>

Reply via email to