@techee requested changes on this pull request.

@b4n Thanks for doing the boring work (at 2 AM :-). Having release notes is a 
big step towards having the actual release.

I made a first quick pass through the notes with some comments. Some are just 
suggestions, feel free to ignore them if you disagree with them.

> @@ -1,5 +1,114 @@
 Geany 2.1 (unreleased)
 
+    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).
+    * Require GLib 2.56 (PR#4199).
+    * Include themes from geany-themes (Issue#4035, PR#4044).
+    * Change placeholders for external printing command (Pynckels, PR#4250).

Maybe "Support additional placeholders..."

> @@ -1,5 +1,114 @@
 Geany 2.1 (unreleased)
 
+    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).
+    * Require GLib 2.56 (PR#4199).
+    * Include themes from geany-themes (Issue#4035, PR#4044).
+    * Change placeholders for external printing command (Pynckels, PR#4250).
+
+    Bug Fixes
+    * Fix Meson build when either fnmatch() or regcomp() is missing on the
+      system (Issue#3618).
+    * Do no silently truncate files containing NUL bytes (PR#3716).

no -> not

> @@ -1,5 +1,114 @@
 Geany 2.1 (unreleased)
 
+    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).
+    * Require GLib 2.56 (PR#4199).
+    * Include themes from geany-themes (Issue#4035, PR#4044).
+    * Change placeholders for external printing command (Pynckels, PR#4250).
+
+    Bug Fixes
+    * Fix Meson build when either fnmatch() or regcomp() is missing on the
+      system (Issue#3618).
+    * Do no silently truncate files containing NUL bytes (PR#3716).
+    * Improve many corner-case encoding detection and conversion (PR#3716).

I'd drop "many" as the sentence is in singular.

> @@ -1,5 +1,114 @@
 Geany 2.1 (unreleased)
 
+    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).
+    * Require GLib 2.56 (PR#4199).
+    * Include themes from geany-themes (Issue#4035, PR#4044).
+    * Change placeholders for external printing command (Pynckels, PR#4250).
+
+    Bug Fixes
+    * Fix Meson build when either fnmatch() or regcomp() is missing on the
+      system (Issue#3618).
+    * Do no silently truncate files containing NUL bytes (PR#3716).
+    * Improve many corner-case encoding detection and conversion (PR#3716).
+    * Fix search entry after editing the toolbar (Issue#3831, PR#3838).
+    * Fix possible invalid memory access when generating user initials on first
+      startup (Issue#3844, PR#3846).
+    * Fix non-deterministic anonymous tag names (Issue#3717, PR#3785).

tag -> symbol

> +    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).
+    * Require GLib 2.56 (PR#4199).
+    * Include themes from geany-themes (Issue#4035, PR#4044).
+    * Change placeholders for external printing command (Pynckels, PR#4250).
+
+    Bug Fixes
+    * Fix Meson build when either fnmatch() or regcomp() is missing on the
+      system (Issue#3618).
+    * Do no silently truncate files containing NUL bytes (PR#3716).
+    * Improve many corner-case encoding detection and conversion (PR#3716).
+    * Fix search entry after editing the toolbar (Issue#3831, PR#3838).
+    * Fix possible invalid memory access when generating user initials on first
+      startup (Issue#3844, PR#3846).
+    * Fix non-deterministic anonymous tag names (Issue#3717, PR#3785).
+    * Fix loosing session when opening several projects (Issue#3897, PR#3898).

loosing -> losing
I'd also replace "when -> after" as it sounds as if it were possible to open 
several projects in parallel

> +    * Improve many corner-case encoding detection and conversion (PR#3716).
+    * Fix search entry after editing the toolbar (Issue#3831, PR#3838).
+    * Fix possible invalid memory access when generating user initials on first
+      startup (Issue#3844, PR#3846).
+    * Fix non-deterministic anonymous tag names (Issue#3717, PR#3785).
+    * Fix loosing session when opening several projects (Issue#3897, PR#3898).
+    * Fix spurious CPU load after running a build command (PR#3902).
+    * Fix emission of the "document-activate" signal, leading to glitches in
+      UI and plugins (Issue#3684, PR#3891).
+    * Fix displaying symbols declared out of order (Issue#4060, PR#4063).
+
+    Interface
+    * Fix translation of the Various preferences tab (Issue#3628, PR#3634).
+    * Do not show redundant None encoding (Issue#3624, PR#3640).
+    * Move "Virtual Spaces" preference to "Editor -> Features" (Issue#3605).
+    * Increase default sidebar width (Issue#3630, PR#3637).

Maybe small enough detail so it can be removed from the notes.

Edit: Or grouped with other small UI improvements - see below.

> +
+    Interface
+    * Fix translation of the Various preferences tab (Issue#3628, PR#3634).
+    * Do not show redundant None encoding (Issue#3624, PR#3640).
+    * Move "Virtual Spaces" preference to "Editor -> Features" (Issue#3605).
+    * Increase default sidebar width (Issue#3630, PR#3637).
+    * Fix focusing the symbol list through key binding (Pascal Baillehache,
+      Issue#3678, PR#3681).
+    * Do not display encodings not supported on the system (PR#3720).
+    * Add support for searching the Messages and Compiler output (PR#3823).
+    * Add various pref to skip "replace in session" confirmation dialog
+      (Issue#3702, PR#3851).
+    * Add support for modern platform-native file selection dialogs (PR#3861).
+    * Fix spurious selection when clicking an externally-modified file
+      (Issue#3906, PR#3909).
+    * Make it easier to wrap search (Issue#1192, PR#4042).

"... when the confirmation dialog is shown"

> +    * Do not show redundant None encoding (Issue#3624, PR#3640).
+    * Move "Virtual Spaces" preference to "Editor -> Features" (Issue#3605).
+    * Increase default sidebar width (Issue#3630, PR#3637).
+    * Fix focusing the symbol list through key binding (Pascal Baillehache,
+      Issue#3678, PR#3681).
+    * Do not display encodings not supported on the system (PR#3720).
+    * Add support for searching the Messages and Compiler output (PR#3823).
+    * Add various pref to skip "replace in session" confirmation dialog
+      (Issue#3702, PR#3851).
+    * Add support for modern platform-native file selection dialogs (PR#3861).
+    * Fix spurious selection when clicking an externally-modified file
+      (Issue#3906, PR#3909).
+    * Make it easier to wrap search (Issue#1192, PR#4042).
+    * Regroup filetypes by letter (PR#3977).
+    * Make the Search & Replace dialog a little more compact (PR#4098).
+    * Make the Date dialog a little more compact (PR#4149).

I'd drop these two. Or maybe together with "Increase default sidebar width" 
above, it could become some "Various UI tweaks" item, listing all the matching 
PRs.

> +    * Do not display encodings not supported on the system (PR#3720).
+    * Add support for searching the Messages and Compiler output (PR#3823).
+    * Add various pref to skip "replace in session" confirmation dialog
+      (Issue#3702, PR#3851).
+    * Add support for modern platform-native file selection dialogs (PR#3861).
+    * Fix spurious selection when clicking an externally-modified file
+      (Issue#3906, PR#3909).
+    * Make it easier to wrap search (Issue#1192, PR#4042).
+    * Regroup filetypes by letter (PR#3977).
+    * Make the Search & Replace dialog a little more compact (PR#4098).
+    * Make the Date dialog a little more compact (PR#4149).
+    * Add filter entry for keybindings preferences (Issue#2848, PR#4192).
+    * Add filter for open documents sidebar (PR#4210).
+
+    Editor
+    * Hide autocompletion and calltip popups when code is scrolled (PR#3560).

Possibly another one for "Various UI tweaks"

> +    * Make it easier to wrap search (Issue#1192, PR#4042).
+    * Regroup filetypes by letter (PR#3977).
+    * Make the Search & Replace dialog a little more compact (PR#4098).
+    * Make the Date dialog a little more compact (PR#4149).
+    * Add filter entry for keybindings preferences (Issue#2848, PR#4192).
+    * Add filter for open documents sidebar (PR#4210).
+
+    Editor
+    * Hide autocompletion and calltip popups when code is scrolled (PR#3560).
+    * Update Scintilla to 5.5.4 and Lexilla to 5.4.2 (PR#4168).
+    * Allow pasting and autocompletion for multiple cursors (Issue#625,
+      Issue#2328, PR#4278).
+
+    Filetypes
+    * R: Add execution command (hieeupomalrf, Issue#3376, PR#3607).
+    * Add Raiku (Perl 6) filetype (PR#3169).

Raiku -> Raku

> +    * Add Prolog filetype (PR#3171).
+    * Improve Nim highlighting (Issue#3520, PR#3648).
+    * Recognize .pyi as Python (Issue#3873, PR#3976).
+    * Support triple-quoted strings in Java (Issue#3995, PR#4000).
+    * Recognize shell scripts when using busybox (Issue#3884, PR#4016).
+    * Improve Groovy comments support (PR#4015).
+    * Update Java keywords (PR#4014).
+    * Add symbols support for Meson and Forth filetypes (PR#4013).
+    * Add Zig filetype (Issue#3724, PR#3974).
+    * Add Dart filetype (Issue#371, PR#3973).
+    * Update Verilog keywords (Javier Mora, PR#4037).
+    * Add SystemVerilog filetype (Javier Mora, PR#4039).
+    * Add Nix filetype (PR#3954).
+    * Update JavaScript keywords (Azq2, PR#3440).
+    * Recognize .tmpl and .vue as HTML (Azq2, PR#3440).
+    * Add LESS and SCSS filetypes (Kirill Zhumarin & Jiří Techet, PR#4095).

Feel free to drop me from these small PRs which I contributed with someone else.

> +    * Improve Nim highlighting (Issue#3520, PR#3648).
+    * Recognize .pyi as Python (Issue#3873, PR#3976).
+    * Support triple-quoted strings in Java (Issue#3995, PR#4000).
+    * Recognize shell scripts when using busybox (Issue#3884, PR#4016).
+    * Improve Groovy comments support (PR#4015).
+    * Update Java keywords (PR#4014).
+    * Add symbols support for Meson and Forth filetypes (PR#4013).
+    * Add Zig filetype (Issue#3724, PR#3974).
+    * Add Dart filetype (Issue#371, PR#3973).
+    * Update Verilog keywords (Javier Mora, PR#4037).
+    * Add SystemVerilog filetype (Javier Mora, PR#4039).
+    * Add Nix filetype (PR#3954).
+    * Update JavaScript keywords (Azq2, PR#3440).
+    * Recognize .tmpl and .vue as HTML (Azq2, PR#3440).
+    * Add LESS and SCSS filetypes (Kirill Zhumarin & Jiří Techet, PR#4095).
+    * Add TOML filetypes (PR#3934).

filetypes -> filetype

> +    * Add symbols support for Meson and Forth filetypes (PR#4013).
+    * Add Zig filetype (Issue#3724, PR#3974).
+    * Add Dart filetype (Issue#371, PR#3973).
+    * Update Verilog keywords (Javier Mora, PR#4037).
+    * Add SystemVerilog filetype (Javier Mora, PR#4039).
+    * Add Nix filetype (PR#3954).
+    * Update JavaScript keywords (Azq2, PR#3440).
+    * Recognize .tmpl and .vue as HTML (Azq2, PR#3440).
+    * Add LESS and SCSS filetypes (Kirill Zhumarin & Jiří Techet, PR#4095).
+    * Add TOML filetypes (PR#3934).
+    * Add Terraform HCL filetype (PR#4246).
+
+    Plugins
+    * FileBrowser: Use `xdg-open` to open external files by default on Linux
+      and others (PR#3815).
+    * SaveActions: Add support for "persistent temp files" (LiquidCake,

It's called "persistent untitled documents" now.

> +    * Add Terraform HCL filetype (PR#4246).
+
+    Plugins
+    * FileBrowser: Use `xdg-open` to open external files by default on Linux
+      and others (PR#3815).
+    * SaveActions: Add support for "persistent temp files" (LiquidCake,
+      PR#3911, PR#4077).
+
+    Windows
+    * Improve Meson support (Biswapriyo Nath, PR#3811, PR#3812).
+    * Use themed title bar (GabrielFrigo & Jiří Techet, Issue#4200, PR#4205).
+
+    API
+    * Add "document-before-save-as" signal (PR#3572).
+    * Add `symbols_get_icon_pixbuf()` (PR#3916).
+    * Add *Plugin Extension* APIs: `plugin_extension_register()`,

Instead of listing the function names (which isn't complete anyway as the main 
part is the `PluginExtension` struct), I'd rather say something like:
```
* Add Plugin Extension API allowing plugins to perform autocompletion, symbol 
goto, symbol highlighting, and calltip display
```
Anyone who'd like to use this API would have to study the documentation anyway.

> @@ -1,5 +1,114 @@
 Geany 2.1 (unreleased)
 
+    General
+    * Improve activation of a running instance (Kondor Dániel, Issue#3531, 
PR#4071).

Maybe something like "Improve focusing the editor window when opening a file 
externally" would be clearer for end users.

> +    * Move "Virtual Spaces" preference to "Editor -> Features" (Issue#3605).
+    * Increase default sidebar width (Issue#3630, PR#3637).
+    * Fix focusing the symbol list through key binding (Pascal Baillehache,
+      Issue#3678, PR#3681).
+    * Do not display encodings not supported on the system (PR#3720).
+    * Add support for searching the Messages and Compiler output (PR#3823).
+    * Add various pref to skip "replace in session" confirmation dialog
+      (Issue#3702, PR#3851).
+    * Add support for modern platform-native file selection dialogs (PR#3861).
+    * Fix spurious selection when clicking an externally-modified file
+      (Issue#3906, PR#3909).
+    * Make it easier to wrap search (Issue#1192, PR#4042).
+    * Regroup filetypes by letter (PR#3977).
+    * Make the Search & Replace dialog a little more compact (PR#4098).
+    * Make the Date dialog a little more compact (PR#4149).
+    * Add filter entry for keybindings preferences (Issue#2848, PR#4192).

I'd drop "entry" here so it's the same as the item below.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4315#pullrequestreview-2880959175
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4315/review/[email protected]>

Reply via email to