@eht16 commented on this pull request.
> }
-
- if (g_utf8_strchr(needles, -1, 'l') != NULL && strstr(haystack->str,
"%l")) {
- g_string_append(errormsg, " %%l");
+ else
+ {
+ switch (placeholder)
+ {
+ case 'p': /* we only end up here if no project are
open, so fallback on %d */
+ ui_set_statusbar(FALSE, _("failed to substitute
%%p, no project active"));
I wonder if the message could be misleading a bit because we *did* substitute
the `%p` placeholder with `%d` and it is no error.
I think we could either rephrase the message to make it more informational
(e.g. `no project active, substituted with %%d`) or just drop it completely.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4318#pullrequestreview-2907316812
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4318/review/[email protected]>
