techee left a comment (geany/geany-plugins#1451)

Ha, thanks! Looks obviously correct and works for me (tested with Czech `ů` and 
`ú` so we have all the `u`s covered ;-).

To my defense, "rangeLength" for which the result is used wasn't sent 
originally to the server since it's not mandatory and is redundant (the server 
can determine it from the start and the end positions). But to workaround

https://github.com/eclipse-lemminx/lemminx/issues/1674

I added it later on and didn't pay enough attention to what I was doing and 
didn't test multibyte characters afterwards. Apparently, `clangd` uses it when 
present and doesn't calculate the range by itself.

By the way, my planned workflow for the LSP plugin is to do the development in 
https://github.com/techee/geany-lsp and only sync it with geany-plugins from 
time to time. So it's best to open issues and PRs there. But don't worry for 
small things like this one.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1451#issuecomment-2987901416
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1451/[email protected]>

Reply via email to