There are already keybindings for standard Geany goto definition/declaration that will get propagated to the LSP server so there is not a real need for another pair of keybindings doing nearly the same. This is confusing for users (see https://github.com/techee/geany-lsp/discussions/79).
The only exception when this could get useful is when users configure the plugin not to use LSP for goto in which case standard Geany goto is used when using Geany goto definition/declaration. In this case, the extra keybinding would still use LSP features and users could choose between the two by using two different keybindings. However, such as feature is hard to discover and probably not used by many and better to make the UI less confusing for users. @frlan @b4n This patch removes 2 translatable strings. Probably not a problem, just can the patch be merged now or should it wait until all translators submit their updates? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1453 -- Commit Summary -- * LSP: Remove keybindings for goto definition/declaration -- File Changes -- M lsp/src/lsp-main.c (6) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1453.patch https://github.com/geany/geany-plugins/pull/1453.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1453 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/[email protected]>
