@techee commented on this pull request.
> @@ -261,7 +261,8 @@ on_configure_response(GtkDialog* dialog, gint response,
> gpointer user_data)
/* If one field is empty, ignore this line (it will be
replaces
at next execution) */
- if ( strlen(impl_list[i])==0 || strlen(head_list[i])==0
)
+ if ( !impl_list[i] || strlen(impl_list[i])==0 ||
> ... ! *x is gonna be quite a tad faster.
...which doesn't matter much in this case but in fact, we have `EMPTY()`
covering both of the tests which will make it quite a bit more readable. I'll
update the patch using `EMPTY()`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1454#discussion_r2160421896
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1454/review/[email protected]>
