@techee approved this pull request.
LGTM and works as expected.
I was curious how Geany behaves memory-wise with this change and these are the
results (this is with some other plugins enabled):
```
VIRT RES SHR
644428 68740 45612 - no webkit plugins loaded and plugin manager not shown
656948 73468 49020 - plugin manager shown and webkit plugins not present
993256 104164 70476 - plugin manager shown and webkit plugins present
69.9g 179204 127552 - webhelper plugin loaded
```
The extra memory used just for loading the plugin manager with webkit plugins
is a bit unfortunate but it's not such a disaster and once users set up their
favorite plugins, they won't open the plugin manager often anyway.
> @@ -563,3 +555,38 @@ plugin_configure (GtkDialog *dialog)
return box1;
}
+
+/* Load module */
+G_MODULE_EXPORT void
+geany_load_module (GeanyPlugin *plugin)
+{
+ /* setup translation */
+ main_locale_init (LOCALEDIR, GETTEXT_PACKAGE);
+
+ /* metadata */
+ plugin->info->name = _("Web helper");
+ plugin->info->description = _("Display a preview web page that gets updated "
+ "upon document saving and provide web "
+ "analysis and debugging tools (aka Web "
+ "Inspector), all using WebKit.");
Just a question since I don't know how intltool behaves - is it OK to split the
string differently than before?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1455#pullrequestreview-2958772221
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1455/review/[email protected]>
