@b4n commented on this pull request.
I didn't yet try these, but it looks mostly sound, thanks. I'll try to dive
deeper tomorrow if I can.
> + dialog=gtk_dialog_new();
+ gtk_window_set_title(GTK_WINDOW(dialog),cTitle);
+
gtk_window_set_transient_for(GTK_WINDOW(dialog),GTK_WINDOW(geany->main_widgets->window));
+ gtk_window_set_destroy_with_parent(GTK_WINDOW(dialog),TRUE);
This could probably be improved further by using `_with_buttons()` and either
use `gtk_dialog_get_widget_for_response()` or
`gtk_dialog_set_response_sensitive()`, but at least the latter will require
some reworking.
> @@ -753,7 +753,7 @@ vcdiff_dir_activated(G_GNUC_UNUSED GtkMenuItem *
> menuitem, gpointer data)
multiple statuses (e.g. Modified and Added)
- diff each file only once
*/
-
g_slist_sort(lst,(GCompareFunc)commititem_compare_by_path);
+ lst =
g_slist_sort(lst,(GCompareFunc)commititem_compare_by_path);
this might change behavior, but likely for the better
> @@ -2007,7 +2007,7 @@ static void scp_tree_store_class_init(GObjectClass
> *class)
FALSE, G_PARAM_READWRITE));
}
-static volatile gsize scp_tree_store_type_id_volatile = 0;
+static gsize scp_tree_store_type_id_volatile = 0;
maybe rename the variable then? :slightly_smiling_face:
> @@ -416,7 +416,7 @@ static gint glspi_keycmd(lua_State* L)
static gint glspi_launch(lua_State* L)
{
- gint argc=lua_gettop(L);
+ gsize argc=lua_gettop(L);
not sure I get that one, but I believe there is a fairly serious bug in the
alloc itself, shouldn't it be
`argv=g_malloc0(sizeof(gchar *)*(argc+1))` (notice the parentheses)?
Maybe we get away with it because of alignment or something, but IIUC it would
likely allocate 7 bytes too few.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1456#pullrequestreview-2959600130
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1456/review/[email protected]>
