This patch avoids widget hierarchy introspection to find GeanyDocument 
corresponding to a notebook tab widget by assigning it to the widget using 
g_object_set_data().

The previous method looking for the Scintilla widget would fail if the 
hierarchy contained another Scintilla widget coming e.g. from a plugin (such as 
the Overview plugin).

Replaces https://github.com/geany/geany/pull/4349

Fixes https://github.com/geany/geany-plugins/issues/730 
Fixes https://github.com/geany/geany-plugins/issues/1149 
Fixes https://github.com/geany/geany-plugins/issues/1180

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/4352

-- Commit Summary --

  * Avoid introspecting widget hierarchy when obtaining doc from page

-- File Changes --

    M src/document.c (61)
    M src/document.h (2)
    M src/notebook.c (2)

-- Patch Links --

https://github.com/geany/geany/pull/4352.patch
https://github.com/geany/geany/pull/4352.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4352
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/[email protected]>

Reply via email to