techee left a comment (geany/geany-plugins#1458) > putting Key_Released_CallBack() in its original position minimizes the > overall diff. Not very important though -- I mostly moved it back to check > how different it actually ended up being.
OK. > More importantly, for me some combinations result in weird double actions > (e.g. Ctrl+- that also zooms out, and Ctrl+0 that also resets zoom). This is > due to the fact that the plugin for some reason work on key releases, and > most of other code uses key presses, so one action is performed upon press, > another upon release. I'd think it makes more sense to consume the press as > well to avoid these double effects. What do you think? I completely forgot about this issue - I wanted to mention it but forgot about it. But instead of doing the extra work to handle both key presses and key releases, what about converting it to use key presses only? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1458#issuecomment-3025386315 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1458/[email protected]>
