@techee commented on this pull request.


> @@ -38,6 +38,10 @@
 #include <glib.h>
 #include <glib/gprintf.h>
 
+#ifndef G_GNUC_FALLTHROUGH
+# define G_GNUC_FALLTHROUGH  /* GLib < 2.60 */
+#endif

> If you do it like that you could prevent the warning with MAX_ALLOWED by 
> undefining the GLib one.

I'm lost - what is MAX_ALLOWED and what warning are you talking about?

> Not that it's necessarily perfect either given you'll get GCC to warn about 
> the implicit fallthroughs…

This will be on older glib versions so I think we don't have to care too much, 
do we?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1479#discussion_r2201449320
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1479/review/[email protected]>

Reply via email to