@b4n requested changes on this pull request.
Works as advertised, I don't see a problem with it.
Though, if @eht16 still likes it better, we could indeed have the menubar item
always visible if it has a keybinding set. I don't have a strong opinion on
this, and I am fine with the current situation as well.
> @@ -279,6 +279,8 @@ enum GeanyKeyBindingID
* @since 1.38 (API 240) */
GEANY_KEYS_PROJECT_NEW_FROM_FOLDER, /**< Keybinding.
* @since 2.0 (API 243) */
+ GEANY_KEYS_TOGGLE_MENUBAR, /**<
Keybinding.
+
* @since 2.1 (API TODO) */
This needs updating (and the API version to match)
```suggestion
* @since 2.2 (API 251) */
```
> @@ -1122,6 +1129,18 @@ static gboolean check_fixed_kb(guint keyval, guint
> state)
return TRUE;
}
}
+ /* temporarily show the menubar again when triggering it while hidden */
+ if (state == 0 && keyval == GDK_KEY_F10 && ! ui_prefs.menubar_visible)
+ {
+ GtkWidget *const geany_menubar_box =
ui_lookup_widget(main_widgets.window, "hbox_menubar");
+ GtkWidget *const geany_menubar =
ui_lookup_widget(main_widgets.window, "menubar1");
+
+ gtk_widget_show(geany_menubar_box);
+ gtk_menu_shell_select_first(GTK_MENU_SHELL(geany_menubar),
TRUE);
+
+ return TRUE;
+ }
+ /* FIXME: handle Alt to focus the menu bar? */
Maybe we should remove this FIXME, or at least make it a TODO or something less
critical?
```suggestion
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4279#pullrequestreview-3053395964
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4279/review/[email protected]>
