memstream left a comment (geany/geany-plugins#1498)

> I probably won't have time to review in coming week, but I'll try to look at 
> this, thanks.
> 
> One thing that'll I surely ask is whether it could be split into smaller 
> commits, one for each feature. If you don't know how to do that, either learn 
> :) or I'll try to do it when reviewing. But it's usually easiest when doing 
> the changes themselves at first (for the future). Basically to split it, you 
> uncommit (but keep the changes themselves, `git reset --soft @^`) and then 
> commit partial pieces (`git add -p`).

I divided the commit into several others; in addition to new features, there 
were several fixes, I moved them into separate commits.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1498#issuecomment-3168389694
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1498/[email protected]>

Reply via email to