@b4n commented on this pull request.
> @@ -2194,7 +2194,7 @@ void ui_add_config_file_menu_item(const gchar
> *real_path, const gchar *label, Gt
{
gchar *base_name;
- base_name = g_path_get_basename(real_path);
+ base_name = g_filename_display_basename(real_path);
We could also do
```c
base_name = g_path_get_basename(real_path);
SETPTR(base_name, utils_get_utf8_from_locale(base_name));
```
and that would be more "Geany-like" (we don't use
[`g_filename_display_basename()`](https://docs.gtk.org/glib/func.filename_display_basename.html)
anywhere yet), but it's slightly less correct (invalid values are not handled
as well, and actual encoding might be different in some corner case situations).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4504#pullrequestreview-3699762085
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/4504/review/[email protected]>
