Why? as noted in #4620 I could not build a working windows 10 install with 
meson, or autogen, or even with a port to cmake.
I tracked it down to an abort() generated out of std::future in Scintilla. I 
patched that.
updated geany to allow for the UNICODE define, which is windows standardish.
updated meson to allow for some windows standardish flags when cross compiling.
updated meson to honor plugin and vte.
updated geany manifest to specify a codepage
editor.c was never initializing sci threading, added.
updated main.c to allow windows execution to recapture console, if launched 
from one.
Pulled meson up to the march=x86-64-v2 standard, and ensured that winver and 
winnt_win32 were exposed in meson, delineating where to look if you need to 
rebuild for i686
After these changes, the geany executable is up to 205KB, and the 
libgeany-0.dll is up to 6.5MB. 

Why x86-64-v2? Geany already uses Msys2, and Msys2 is talking about updating 
their build from 
[nocona](https://github.com/msys2/MINGW-packages/discussions/29999), as support 
for older processors falls off.

Fixes #4624 
Fixes #4631 
Fixes #4625 
Fixes #4626 
Fixes #4630 
Fixes #4620 

Contributed under GPL-2.0-or-later with my thanks to @nyamatongwe for help with 
scintilla.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/4632

-- Commit Summary --

  * Example cross compile file for meson
  * Fix #4624 by adding flag handlers
  * FIX #4631 update manifest to 64bit, and UTF-8
  * FIX #4625 if UNICODE is defined, setcurrentdirectory points to 
setcurrentdirectoryw and needs wchars
  * FIX #4626 reattach to console, if one is present
  * FIX #4625 if UNICODE is defined, there is a namespace collision
  * FIX #4630 init SCI threading
  * FIX #4620 GTK crashes fairly consistently if std::future is used; Wrap to 
glib instead

-- File Changes --

    M geany.exe.manifest (5)
    M meson.build (46)
    M scintilla/src/EditView.cxx (44)
    M scintilla/src/Editor.cxx (95)
    M src/editor.c (2)
    M src/encodings.c (166)
    M src/encodingsprivate.h (14)
    M src/main.c (17)
    M src/win32.c (21)
    A ucrt64.cross.ini (23)

-- Patch Links --

https://github.com/geany/geany/pull/4632.patch
https://github.com/geany/geany/pull/4632.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4632
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/[email protected]>

Reply via email to