advice2020 left a comment (geany/geany-plugins#1590)

@Skif-off
Damn Skif this is good! :)
I was not thinking about that 3rd parameter you included, that was a good idea 
so that user can choose how each string is specifically replaced.

--------------------------------------------------

UNDO
Only one thing I noticed that could be slightly dangerous is how "undo" action 
works with this script.
Does not undo the entire process (entire document / entire selection).
Instead it performs undo actions per specific string and one string instance at 
at time.
I would not add any dialogs or anything like that, but maybe can add a note in 
comment section at top of script, just to remind user that it might be a good 
idea to save before running this script.
This way user can just close document to "undo" the entire process.
Maybe something similar to
```
Note:
Cannot undo entire find and replace action at the same time, only one replaced 
string can be undone at a time.   
Therefore it is recommended to save document before running this script.
```

--------------------------------------------------

This is another great script
Thank you very much for creating this and for all the help you have provided 
with Geany related questions/requests.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1590#issuecomment-5053235448
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/issues/1590/[email protected]>

Reply via email to