fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412407398
##########
File path: cpp/src/arrow/dataset/dataset.cc
##########
@@ -72,36 +78,15 @@ Result<std::shared_ptr<ScannerBuilder>> Dataset::NewScan() {
return NewScan(std::make_shared<ScanContext>());
}
-bool Dataset::AssumePartitionExpression(
- const std::shared_ptr<ScanOptions>& scan_options,
- std::shared_ptr<ScanOptions>* simplified_scan_options) const {
- if (partition_expression_ == nullptr) {
- if (simplified_scan_options != nullptr) {
- *simplified_scan_options = scan_options;
- }
- return true;
- }
+FragmentIterator Dataset::GetFragments() { return GetFragments(scalar(true)); }
- auto expr = scan_options->filter->Assume(*partition_expression_);
- if (expr->IsNull() || expr->Equals(false)) {
- // selector is not satisfiable; yield no fragments
- return false;
+FragmentIterator Dataset::GetFragments(std::shared_ptr<Expression> predicate) {
+ if (partition_expression_) {
Review comment:
A unit test triggered a segfault. I added this to move on to the next
failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
