mr-smidge commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-623353035
Hi @zgramana (and @eerhardt). I was independently working on nullable array builder support (but have not been able to contribute just yet as my organisation needs to sign a CCLA). You beat me to it :-). However, I notice that you have baked in "core" validity buffer support into `BooleanArray.Builder`, and then other array builders nest a `BooleanArray.Builder` as their validity buffer, even though a bool array builder contains both a value and validity buffer. I took a slightly different approach, whereby I created an independent "bit buffer builder" that packs bits into an `ArrowBuffer` of bytes. Array builders then use a bit buffer builder for their validity map, and the boolean array builder uses two (one for values, one for validity). Once the CCLA is sorted, would there be any appetite for a PR that makes this refactoring? (In my personal opinion, it is cleaner not to nest `BooleanArray.Builder` within other builders - and this was my motivation for the bit buffer builder.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
