tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-625704614


   > I think it would be good to have a set of tests ensuring that the behavior 
of the empty buffer is consistent. For example, refcnt, release/allocate, etc. 
That way, if someone changes the noop reference manager which this is depending 
on in the future, we don't break the expected behavior of an EmptyBuf as used 
by all the vector classes. Other than that, this looks good.
   
   Good suggestion, seems empty ArrowBuf was used in vectors before populating 
data. I have added a set of tests in TestValueVector.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to