fsaintjacques commented on a change in pull request #7245:
URL: https://github.com/apache/arrow/pull/7245#discussion_r429372456
##########
File path: r/src/arrow_types.h
##########
@@ -176,64 +37,21 @@ inline constexpr Rbyte default_value<RAWSXP>() {
} // namespace Rcpp
-namespace arrow {
-namespace r {
-
-template <typename T>
-inline std::shared_ptr<T> extract(SEXP x) {
- return Rcpp::ConstReferenceSmartPtrInputParameter<std::shared_ptr<T>>(x);
-}
-
-} // namespace r
-} // namespace arrow
-
#if defined(ARROW_R_WITH_ARROW)
-#include <arrow/api.h>
-#include <arrow/c/bridge.h>
-#include <arrow/compute/api.h>
-#include <arrow/csv/reader.h>
-#include <arrow/dataset/api.h>
-#include <arrow/filesystem/filesystem.h>
-#include <arrow/filesystem/localfs.h>
-#include <arrow/filesystem/s3fs.h>
-#include <arrow/io/compressed.h>
-#include <arrow/io/file.h>
-#include <arrow/io/memory.h>
-#include <arrow/ipc/feather.h>
-#include <arrow/ipc/reader.h>
-#include <arrow/ipc/writer.h>
-#include <arrow/json/reader.h>
+#include <arrow/buffer.h> // for RBuffer definition below
Review comment:
`RBuffer` is a templated class, the definition must be in the header and
all it's dependencies must also be included in the headers.
In other words, by moving `RBuffer` in it's own file, the using classes will
also need to include this new header + the original `<arrow/buffer.h>`, e.g. no
benefits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
