zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429715403
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -238,5 +238,27 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public
DatasetFactory {
util::optional<util::string_view> RemovePartitionBaseDir(util::string_view
path);
};
+class ARROW_DS_EXPORT SingleFileDatasetFactory : public DatasetFactory {
Review comment:
One question: can we add a construction function (see the newest
changes) `FileSystemDatasetFactory::Make(std::string uri,
std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options)` to
`FileSystemDatasetFactory`, for reading a single file from an uri? This is
similar to functionality of `SingleFileDataset`.
The original reason of creating `SingleFileDataset` is to avoid passing file
system object via JNI. Passing such objects can make the bridge even
complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
