nealrichardson opened a new pull request #7308:
URL: https://github.com/apache/arrow/pull/7308


   Was curious how easy this would be and what issues I'd run into. So far I've 
only done `sum()` but will also add mean, min, max.
   
   Issues so far (cc @wesm):
   
   * See workarounds in 
[sum.Array](https://github.com/apache/arrow/compare/master...nealrichardson:r-sum?expand=1#diff-695287341c6d5011a12d7d9bd3ae07adR350-R357).
 (1) missing/null values are always dropped, while R provides an option for how 
to treat missingness. Interestingly, it looks like min and max do have this 
null option supported (in `MinMaxOptions`) but sum and mean do not (yet).
   * (2) There is no sum method for boolean type
   * There is no sum implemented for Scalars, which may be fine (I would expect 
it to be no-op for numeric types, just thought logically it maybe shouldn't 
error)
   * Summing integers seems to promote to return int64 if given int32 (I didn't 
try with smaller ints), even when overflow is not a danger (I was adding 
numbers 1 to 5). It would be nice if it returned the same type it got unless it 
has to go bigger to avoid overflow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to