rymurr commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r433127439
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java
##########
@@ -163,8 +163,22 @@ public void clear() {
return fieldVectors.stream().collect(Collectors.toList());
}
+ /**
+ * gets a vector by name.
+ *
+ * if name occurs multiple times this returns the first inserted entry for
name
+ */
public FieldVector getVector(String name) {
Review comment:
Agreed, this now matches with the `Schema` implementation. I think we
should either:
i) deprecate the `name` based methods
ii) document that these methods are unsuitable for tight loops.
Any thoughts on which is more sensible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
