tianchen92 commented on a change in pull request #7231:
URL: https://github.com/apache/arrow/pull/7231#discussion_r433727922
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowFooter.java
##########
@@ -96,17 +126,40 @@ public Schema getSchema() {
return recordBatches;
}
+ public Map<String, String> getMetaData() {
+ return metaData;
+ }
+
@Override
public int writeTo(FlatBufferBuilder builder) {
int schemaIndex = schema.getSchema(builder);
Footer.startDictionariesVector(builder, dictionaries.size());
int dicsOffset = writeAllStructsToVector(builder, dictionaries);
Footer.startRecordBatchesVector(builder, recordBatches.size());
int rbsOffset = writeAllStructsToVector(builder, recordBatches);
+
+ int metaDataOffset = 0;
+ if (metaData != null) {
+ int[] metadataOffsets = new int[metaData.size()];
Review comment:
Actually similar logic exist in Schema for writing metadata, I extracted
a static write method in FBSerializables for reuse purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
