pitrou commented on a change in pull request #7357:
URL: https://github.com/apache/arrow/pull/7357#discussion_r438718661
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -48,6 +48,16 @@ struct AsciiUpper {
}
};
+struct AsciiLower {
+ template <typename... Ignored>
+ static std::string Call(KernelContext*, const util::string_view& val) {
+ std::string result = val.to_string();
Review comment:
For `ascii_upper`, the strategy should be simple:
* keep the same null bitmap buffer
* recompute a similar offsets buffer, but without the base offset
* allocate a same-size values buffer, and convert it in one pass (no need to
iterate over individual array elements)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
