bkietz commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r439503475
##########
File path: cpp/src/arrow/dataset/file_base.h
##########
@@ -45,82 +46,150 @@ namespace dataset {
/// be read like a file
class ARROW_DS_EXPORT FileSource {
public:
- // NOTE(kszucs): it'd be better to separate the BufferSource from FileSource
- enum SourceKind { PATH, BUFFER };
-
FileSource(std::string path, std::shared_ptr<fs::FileSystem> filesystem,
- Compression::type compression = Compression::UNCOMPRESSED,
- bool writable = true)
+ Compression::type compression = Compression::UNCOMPRESSED)
Review comment:
I agree that `FileSource` would benefit from refactoring but I think
that doing so further in this PR (including resorbing `WritableFileSource`) is
not necessary. I'll make a follow up JIRA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
