itamarst commented on a change in pull request #7169:
URL: https://github.com/apache/arrow/pull/7169#discussion_r441564235
##########
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##########
@@ -1688,8 +1698,12 @@ static Status GetPandasWriterType(const ChunkedArray&
data, const PandasOptions&
break;
case Type::TIMESTAMP: {
const auto& ts_type = checked_cast<const TimestampType&>(*data.type());
- // XXX: Hack here for ARROW-7723
- if (ts_type.timezone() != "" && !options.ignore_timezone) {
+ if (options.timestamp_as_object && ts_type.unit() != TimeUnit::NANO) {
+ // Nanoseconds are never out of bounds for pandas, so in that case
Review comment:
I don't understand this comment—is there an extra negative clause in
here? It seems the opposite of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
